Re: [PATCH for-next] brd: use cond_resched instead of cond_resched_rcu

[Hannes Reinecke <hare@xxxxxxx>]

On 6/14/23 15:35, Pankaj Raghav wrote:
> The body of the loop is run without RCU lock held. Use the regular
> cond_resched() instead of cond_resched_rcu().
>
> Fixes: 786bb0245881 ("brd: use XArray instead of radix-tree to index backing pages")
> Suggested-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Signed-off-by: Pankaj Raghav <p.raghav@xxxxxxxxxxx>
> ---
>   drivers/block/brd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index 2f71376afc71..970bd6ff38c4 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -111,7 +111,7 @@ static void brd_free_pages(struct brd_device *brd)
>   
>   	xa_for_each(&brd->brd_pages, idx, page) {
>   		__free_page(page);
> -		cond_resched_rcu();
> +		cond_resched();
>   	}
>   
>   	xa_destroy(&brd->brd_pages);

Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes