On 6/13/23 1:02 PM, Christoph Hellwig wrote:
>> +static bool blkdev_pr_allowed(struct block_device *bdev, fmode_t mode)
>
> With my resent series the use of fmode_t in the block layer has been
> replaced with a new blk_mode_t, so you'll need to rebase.
Okay I will rebase on that in the next version.
>
>> +{
>> + if (capable(CAP_SYS_ADMIN))
>> + return true;
>> +
>> + /* no sense to make reservations for partitions */
>> + if (bdev_is_partition(bdev))
>> + return false;
>
> I think we should disallow the PR ioctls for partitions entirely.
> Yes, that's a change of behavior (and should be a separate patch),
> but this is the right time to fix it.
Okay I will make it into a separate patch later.
> Otherwise this change log good, thanks a lot!
Thanks for the comment and suggestions!
--
Thanks,
Jingbo
