On 6/9/23 17:22, John Pittman wrote: > Thanks alot for responding Martin. Forgive my ignorance; just trying > to gain understanding. For example, if we find a device with a 2TiB > max discard (way too high for any device to handle reasonably from > what I've seen), and we make a quirk for it that brings the max > discard down, how do we decide what value to bring that down to? > Would we ask the hardware vendor for an optimal value? Is there some > way we could decide the value? Thanks again for any help. asking a H/W vendor is definitely good start, but you have to test that value and make sure it is working before adding a quirk is right way to go, because sometimes those values won't work from my experience ... Also, in absence of information from H/W vendor I'd run few experiments with the range of this values to establish the correctness that will not be too low to significantly degrade the performance or to high to create potential problems. -ck
