On Wed, Jun 07, 2023 at 03:10:59PM +0200, Alexander Gordeev wrote: > On Thu, May 11, 2023 at 03:13:34AM +0200, Damien Le Moal wrote: > ... > Hi Damien et al, > > This patch aka commit eca2040972b4 ("scsi: block: ioprio: > Clean up interface definition") in -next breaks LTP test > (at least on s390): > > # ./ioprio_set03 > tst_test.c:1558: TINFO: Timeout per run is 0h 00m 30s > ioprio_set03.c:39: TFAIL: ioprio_set IOPRIO_CLASS_BE prio 8 should not work > ioprio_set03.c:47: TINFO: tested illegal priority with class NONE > ioprio_set03.c:50: TPASS: returned correct error for wrong prio: EINVAL (22) > > Summary: > passed 1 > failed 1 > broken 0 > skipped 0 > warnings 0 > > Thanks! Hello Alex, The LTP failure requires the following patches to LTP: https://lore.kernel.org/ltp/CACRpkdYdtgcLSqovV-HwZ9PvSXFBZv5wdU3KzasMR1wHgah4kg@xxxxxxxxxxxxxx/T/#t Unfortunately, the LTP patches seem to not be available on the archive. However, considering that the LTP patches decided to keep the test case that sets a priority level out of range, they also require this block layer patch: https://lore.kernel.org/linux-block/20230530061307.525644-1-dlemoal@xxxxxxxxxx/T/ The patch would have to go via Martin's tree, since that is where commit eca2040972b4 ("scsi: block: ioprio: Clean up interface definition") is queued. Kind regards, Niklas