On Tue, Jun 06, 2023 at 10:03:45AM +0800, Ming Lei wrote: > On Mon, Jun 05, 2023 at 05:27:13PM -0400, Kent Overstreet wrote: > > This patch reworks bio_for_each_segment_all() to be more inline with how > > the other bio iterators work: > > > > - bio_iter_all_peek() now returns a synthesized bio_vec; we don't stash > > one in the iterator and pass a pointer to it - bad. This way makes it > > clearer what's a constructed value vs. a reference to something > > pre-existing, and it also will help with cleaning up and > > consolidating code with bio_for_each_folio_all(). > > by-value is more readable & clean, the current by-reference is just for aligning > with original interface. This is the fourth or fifth time this patch set has been out on the list, and I specifically asked you to review it awhile back, and you're just now looking at it?
