Re: [PATCH 3/3] scsi: simplify scsi_stop_queue()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/4/23 15:54, Bart Van Assche wrote:
On 6/2/23 09:38, mwilck@xxxxxxxx wrote:
@@ -2910,6 +2904,13 @@ scsi_target_block(struct device *dev)
                      device_block);
      else
          device_for_each_child(dev, NULL, target_block);
+
+    /*
+     * SCSI never enables blk-mq's BLK_MQ_F_BLOCKING flag,
+     * so blk_mq_wait_quiesce_done() comes down to just synchronize_rcu().
+     * Just calling it once is enough.
+     */
+    synchronize_rcu();
  }
  EXPORT_SYMBOL_GPL(scsi_target_block);

The above comment is wrong. See also commit b125bb99559e ("scsi:
core: Support setting BLK_MQ_F_BLOCKING").

Well, this patch got written before your patchset has been posted.
But yeah, we'll be updating it.

Cheers,

Hannes
--
Dr. Hannes Reinecke                Kernel Storage Architect
hare@xxxxxxx                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux