On Mon, Jun 5, 2023 at 1:47 PM Jinpu Wang <jinpu.wang@xxxxxxxxx> wrote: > > Hi Masahiro, > > > On Sat, Jun 3, 2023 at 6:59 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > With CONFIG_BLK_DEV_RNBD_CLIENT=m and CONFIG_BLK_DEV_RNBD_SERVER=y > > (or vice versa), rnbd-common.o is linked to a module and also to > > vmlinux even though CFLAGS are different between builtins and modules. > > > > This is the same situation as fixed by commit 637a642f5ca5 ("zstd: > > Fixing mixed module-builtin objects"). > > > > Turn rnbd_access_mode_str() into an inline function. > Thx for you fix, but Guoqing has a slightly different patch in the queue: > > https://lore.kernel.org/linux-block/CAMGffEnDjAP3zqytmsYxacvUROLKZj+KhH6LOXicOoPhS9FJJQ@xxxxxxxxxxxxxx/ > LGTM. Thank you. -- Best Regards Masahiro Yamada