On Sat, May 27, 2023 at 09:20:30AM -0700, Bart Van Assche wrote: > On 5/26/23 20:16, Luis Chamberlain wrote: > > So I see this as a critical fix too. And it gets me wondering what has > > happened for 512 byte controllers on 4K PAGE_SIZE? > > What is a "512 byte controller"? Most storage controllers I'm familiar with > support DMA segments well above 4 KiB. Nevermind, there shouldn't be controllers as such. > I will look into this. > > > The way I'm thinking about this is, if this is a fix for stable too, > > what would a minimum safe stable fix be like? And then after whatever > > we need to make it better (non stable fixes). > > Hmm ... doesn't the "upstream first" rule apply to stable kernels? > Shouldn't only patches land in stable kernels that are already > upstream instead of applying different patches on stable kernels? That's right, so the question is, is there a way to make simpler modifications which might be sensible for this situation for stable first, and then enhancements which don't go to stable on top ? What would the minimum fix look like for stable? Luis