Re: [RFC PATCH v2 2/3] mm: Provide a function to get an additional pin on a page

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [RFC PATCH v2 2/3] mm: Provide a function to get an additional pin on a page
From: David Howells <dhowells@xxxxxxxxxx>
Date: Fri, 26 May 2023 06:50:09 +0100
Cc: dhowells@xxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, Hillf Danton <hdanton@xxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
In-reply-to: <CAHk-=win3ttfr2xb1JcGroPSOoqGs0GooZq0DLsRtZzXUH5YeQ@mail.gmail.com>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
References: <CAHk-=win3ttfr2xb1JcGroPSOoqGs0GooZq0DLsRtZzXUH5YeQ@mail.gmail.com> <20230525223953.225496-1-dhowells@redhat.com> <20230525223953.225496-3-dhowells@redhat.com>

Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> > +       if (page == ZERO_PAGE(0))
> > +               return;
> 
> You added that nice "is_zero_folio()", and then you did the above anyway..

Bah.  Missed it because it was in a different patch.

David

References:
- Re: [RFC PATCH v2 2/3] mm: Provide a function to get an additional pin on a page
  - From: Linus Torvalds
- [RFC PATCH v2 0/3] block: Make old dio use iov_iter_extract_pages() and page pinning
  - From: David Howells
- [RFC PATCH v2 2/3] mm: Provide a function to get an additional pin on a page
  - From: David Howells

Prev by Date: Re: [PATCH -next v2] block: Fix the partition start may overflow in add_partition()
Next by Date: Re: [PATCH v5 00/20] bio: check return values of bio_add_page
Previous by thread: Re: [RFC PATCH v2 2/3] mm: Provide a function to get an additional pin on a page
Next by thread: Re: [RFC PATCH v2 2/3] mm: Provide a function to get an additional pin on a page
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]