On Tue, May 23, 2023 at 03:30:16PM -0700, Bart Van Assche wrote: > static inline void blk_mq_sched_requeue_request(struct request *rq) > { > - if (rq->rq_flags & RQF_USE_SCHED) { > - struct request_queue *q = rq->q; > - struct elevator_queue *e = q->elevator; > - > - if (e->type->ops.requeue_request) > - e->type->ops.requeue_request(rq); > - } > + if (rq->rq_flags & RQF_USE_SCHED) > + rq->rq_flags |= RQF_REQUEUED; > } I'd drop this helper function if we go down this way. But maybe we might just want to keep the method. Sorry for the noise.