On 5/20/23 1:40 AM, Hengqi Chen wrote:
Currently, several BCC ([0]) tools (biosnoop/biostacks/biotop) use kprobes to blk_account_io_start/blk_account_io_done to implement their functionalities. This is fragile because the target kernel functions may be renamed ([1]) or inlined ([2]). So introduces two new tracepoints for such use cases. [0]: https://github.com/iovisor/bcc [1]: https://github.com/iovisor/bcc/issues/3954 [2]: https://github.com/iovisor/bcc/issues/4261 Tested-by: Francis Laniel <flaniel@xxxxxxxxxxxxxxxxxxx> Signed-off-by: Hengqi Chen <hengqi.chen@xxxxxxxxx>
I tested with my local VM, enabled the tracepoint and did see the trace_pipe printout nicely. If the patch is accepted, we will enhance related bcc-tools/libbpf-tools with these tracepoints so they can continue to work with newer kernels. Tested-by: Yonghong Song <yhs@xxxxxx>