On Fri, May 19, 2023 at 12:55:45PM -0700, Bart Van Assche wrote: >> LIST_HEAD(rq_list); >> - struct request *rq, *next; >> + LIST_HEAD(flush_list); >> + struct request *rq; >> spin_lock_irq(&q->requeue_lock); >> list_splice_init(&q->requeue_list, &rq_list); >> + list_splice_init(&q->flush_list, &flush_list); >> spin_unlock_irq(&q->requeue_lock); > > "rq_list" stands for "request_list". That name is now confusing since this patch > add a second request list (flush_list). It is. But I think you were planning on doing a bigger rework in this area anyway?