On Sat, May 20, 2023 at 01:00:37AM +0100, David Howells wrote: > Provide a splice_read stub for Ext4. This does the inode shutdown check > before proceeding. Splicing from DAX files and O_DIRECT fds is handled by > the caller. Not sure I'd call this a stub, but then again I'm not a native speaker. The patch itself looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>