RE: [PATCH 8/8] block: don't pass a bio to bio_try_merge_hw_seg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>@@ -934,11 +934,10 @@ static bool bvec_try_merge_page(struct bio_vec *bv, struct page *page,
>  * size limit.  This is not for normal read/write bios, but for passthrough
>  * or Zone Append operations that we can't split.
>  */
>-static bool bio_try_merge_hw_seg(struct request_queue *q, struct bio *bio,
>-                                 struct page *page, unsigned len,
>-                                 unsigned offset, bool *same_page)
>+static bool bvec_try_merge_hw_page(struct request_queue *q, struct bio_vec *bv,
>+                struct page *page, unsigned len, unsigned offset,
>+                bool *same_page)
> {

There is a static because there is no external call based on the current change point.
So, I will modify it when using this function later.
Thank you for organizing the functions that can be used for common use.

Looks good to me,

Reviewed-by: Jinyoung Choi <j-young.choi@xxxxxxxxxxx>




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux