On Thu, May 18, 2023 at 06:23:22AM +0200, Christoph Hellwig wrote: > Implement a set of holder_ops that shut down the file system when the > block device used as log or RT device is removed undeneath the file > system. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> > --- > fs/xfs/xfs_super.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index eb469b8f9a0497..75d37bbc5415fc 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -377,6 +377,17 @@ xfs_setup_dax_always( > return 0; > } > > +static void > +xfs_hop_mark_dead( > + struct block_device *bdev) I'd prefer these ops to be named "xfs_bdev_...." to indicate the are fs bdev methods similar to how the super ops use "xfs_fs_...." to indicate they are fs superblock methods.... Other that this this is fine. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
