Re: [PATCH V2 2/2] blk-mq: make sure elevator callbacks aren't called for passthrough request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ming Lei <ming.lei@xxxxxxxxxx>
Subject: Re: [PATCH V2 2/2] blk-mq: make sure elevator callbacks aren't called for passthrough request
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 17 May 2023 09:22:18 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Bart Van Assche <bvanassche@xxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx
In-reply-to: <ZGNBKSaULn/gpsL0@ovpn-8-19.pek2.redhat.com>
References: <20230515144601.52811-1-ming.lei@redhat.com> <20230515144601.52811-3-ming.lei@redhat.com> <c0c4fc86-29ff-5a70-1f32-dca9af4602d5@acm.org> <ZGKUehOEnKThjFpR@kbusch-mbp> <ZGLad5yYUDJBleBQ@ovpn-8-19.pek2.redhat.com> <20230516062409.GB7325@lst.de> <ZGNBKSaULn/gpsL0@ovpn-8-19.pek2.redhat.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Tue, May 16, 2023 at 04:39:05PM +0800, Ming Lei wrote:
> I can understand the point, but it may not be done by single flag,

Can you explain why?  Note that we also already have RQF_ELVPRIV for
any request that has elevator private data.  I don't really think we
need a third flag.

Follow-Ups:
- Re: [PATCH V2 2/2] blk-mq: make sure elevator callbacks aren't called for passthrough request
  - From: Ming Lei

References:
- [PATCH V2 0/2] blk-mq: handle passthrough request as really passthrough
  - From: Ming Lei
- [PATCH V2 2/2] blk-mq: make sure elevator callbacks aren't called for passthrough request
  - From: Ming Lei
- Re: [PATCH V2 2/2] blk-mq: make sure elevator callbacks aren't called for passthrough request
  - From: Bart Van Assche
- Re: [PATCH V2 2/2] blk-mq: make sure elevator callbacks aren't called for passthrough request
  - From: Keith Busch
- Re: [PATCH V2 2/2] blk-mq: make sure elevator callbacks aren't called for passthrough request
  - From: Ming Lei
- Re: [PATCH V2 2/2] blk-mq: make sure elevator callbacks aren't called for passthrough request
  - From: Christoph Hellwig
- Re: [PATCH V2 2/2] blk-mq: make sure elevator callbacks aren't called for passthrough request
  - From: Ming Lei

Prev by Date: Re: [PATCH V2 1/2] blk-mq: don't queue plugged passthrough requests into scheduler
Next by Date: Re: [PATCH for-next 2/2] nvme: optimise io_uring passthrough completion
Previous by thread: Re: [PATCH V2 2/2] blk-mq: make sure elevator callbacks aren't called for passthrough request
Next by thread: Re: [PATCH V2 2/2] blk-mq: make sure elevator callbacks aren't called for passthrough request
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]