On 5/17/23 07:33, Bart Van Assche wrote:
> Track the position (sector_t) of the most recently dispatched request
> instead of tracking a pointer to the next request to dispatch. This
> patch is the basis for patch "Handle requeued requests correctly".
> Without this patch it would be significantly more complicated to make
> sure that zoned writes are dispatched in LBA order per zone.
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Cc: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
> Cc: Ming Lei <ming.lei@xxxxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
Looks OK. One nit below.
Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
> @@ -433,9 +445,11 @@ static struct request *__dd_dispatch_request(struct deadline_data *dd,
> * batches are currently reads XOR writes
> */
> rq = deadline_next_request(dd, per_prio, dd->last_dir);
> - if (rq && dd->batching < dd->fifo_batch)
> + if (rq && dd->batching < dd->fifo_batch) {
> /* we have a next request are still entitled to batch */
Nit: while at it, please fix this comment:
...next request are still... -> ...next request and are still...
--
Damien Le Moal
Western Digital Research
