On Wed, May 10, 2023 at 05:59:41PM +0900, Jinyoung CHOI wrote: > bip_for_each_vec() performs the iteration in a page unit. > > Since a bio_vec of bip is composed of multi-page in the block, a macro > that can be carried out in multi-page units has been added. The naming here is a bit confused. The rest of the block layers uses _segment for the per-page iterators and _vec for the one that doesn't break up. I'd suggest we follow this naming scheme here. And also skip the extra for_each_mp_bvec level, just like we don't have that intermediate level for bio_for_each_vec