On 5/12/23 8:31 AM, Christoph Hellwig wrote: > On Fri, May 12, 2023 at 01:29:56AM -0700, Chaitanya Kulkarni wrote: >> Allow user to set the QUEUE_FLAG_NOWAIT optionally using module >> parameter to retain the default behaviour. Also, update respective >> allocation flags in the write path. Following are the performance >> numbers with io_uring fio engine for random read, note that device has >> been populated fully with randwrite workload before taking these >> numbers :- > > Why would you add a module option, except to make everyones life hell? Yeah that makes no sense. Either the driver is nowait compatible and it should just set the flag, or it's not. -- Jens Axboe
