On 03/12/2017 06:56 PM, Jason Yan wrote: > > On 2017/3/12 6:29, Jens Axboe wrote: >> On 03/10/2017 12:32 AM, Jason Yan wrote: >>> Fixes the following sparse warning: >>> >>> drivers/block/brd.c:411:15: warning: symbol 'rd_size' was not declared. >>> Should it be static? >> >> If you do a search on this topic, you'll find others that attempted >> to do the same. Arm uses it for tag parsing, for some reason, your >> patch below would break it. >> >> It'd be great if this was fixed up for real, though. >> > > how about fix this like this, looks ugly but works: > > #ifndef CONFIG_ARM > static > #endif No, that solves nothing, and is arguably worse. Either leave it alone, perhaps with a comment to prevent others from making the same error, or fix it for real. -- Jens Axboe
