On 03/04/2017 08:01 AM, Paolo Valente wrote: > Some patch generates WARNINGS with checkpatch.pl, but these WARNINGS > seem to be either unavoidable for the involved pieces of code (which > the patch just extends), or false positives. The code in this series looks reasonably clean from a code style point of view, but please address all checkpatch warnings that can be addressed easily. A few examples of such checkpatch warnings: ERROR: "foo * bar" should be "foo *bar" WARNING: Symbolic permissions 'S_IRUGO|S_IWUSR' are not preferred. Consider using octal permissions '0644'. Thanks, Bart.