Hello, On Tue 28-02-17 11:54:41, Tejun Heo wrote: > It generally looks good to me. Thanks for review! > The only worry I have is around wb_shutdown() synchronization and if that > is actually an issue it shouldn't be too difficult to fix. Yeah, I'll have a look at that. > The other thing which came to mind is that the congested->__bdi sever > semantics. IIRC, that one was also to support the "bdi must go away now" > behavior. As bdi is refcnted now, I think we can probably just let cong > hold onto the bdi rather than try to sever the ref there. So currently I get away with __bdi not being a proper refcounted reference. If we were to remove the clearing of __bdi, we'd have to make it into refcounted reference which is sligthly ugly as we need to special-case embedded bdi_writeback_congested structures. Maybe it will be a worthwhile cleanup but for now I left it alone... Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
