On 02/27/2017 11:41 AM, Sagi Grimberg wrote: > >>>>> blk_mq_alloc_request_hctx() allocates a driver request directly, unlike >>>>> its blk_mq_alloc_request() counterpart. It also crashes because it >>>>> doesn't update the tags->rqs map. >>>>> >>>>> Fix it by making it allocate a scheduler request. >>>> >>>> All three look good to me. Would you mind respinning #1, it doesn't >>>> apply on top of the reserved tag patch. >>> >>> Yup, I had those based on Sagi's original patches for some reason. I >>> fat-fingered send-email, sent as a reply to the original patch 1 instead >>> of this email. >> >> I got it, applied all 3, thanks Omar! > > FWIW, you can add my: > > Tested-by: Sagi Grimberg <sagi@xxxxxxxxxx> Done, I fixed up your typo, though :-) > Although I didn't try to trigger reserved vs. normal tag > competition which will never ever happen for nvmf btw, but > I assume it can happen in drivers who use reserved for error > handling. As long as we verify they work independently, there should not be a need to check that edge case separately. We should have identical behavior there now to previously. -- Jens Axboe
