Re: [PATCH v1 02/14] block: introduce bio_remove_last_page()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ming Lei <tom.leiming@xxxxxxxxx>
Subject: Re: [PATCH v1 02/14] block: introduce bio_remove_last_page()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 25 Feb 2017 10:23:06 -0800
Cc: Shaohua Li <shli@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to: <1487950971-1131-3-git-send-email-tom.leiming@gmail.com>
User-agent: Mutt/1.7.1 (2016-10-04)

On Fri, Feb 24, 2017 at 11:42:39PM +0800, Ming Lei wrote:
> MD need this helper to remove the last added page, so introduce
> it.

If MD really has a valid use case for this it should open code the
operation.  The semantics look deeply fishy to me.

Follow-Ups:
- Re: [PATCH v1 02/14] block: introduce bio_remove_last_page()
  - From: Ming Lei

References:
- [PATCH v1 00/14] md: cleanup on direct access to bvec table
  - From: Ming Lei
- [PATCH v1 02/14] block: introduce bio_remove_last_page()
  - From: Ming Lei

Prev by Date: Re: [GIT PULL] Block pull request for- 4.11-rc1
Next by Date: Re: [WIP BRANCH] cgroups support in bfq-mq WIP branch
Previous by thread: [PATCH v1 02/14] block: introduce bio_remove_last_page()
Next by thread: Re: [PATCH v1 02/14] block: introduce bio_remove_last_page()
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux