On Thu, Feb 16, 2017 at 11:45:29AM -0700, Scott Bauer wrote:
> > + if (check_opal_support(dev) < 0) {
> > pr_warn("Opal is not supported on this device\n");
> > - opal_dev->initialized = true;
> > + kfree(dev);
> > + return NULL;
>
> We're going to have to change this check_opal_support to be != 0 instead of < 0.
Yes. And we should simply turn all these printk into pr_debug anway -
not having OPAL is a prefectly fine condition, no need to spam the log
for it.
And btw, I think we should check for bit 0 in OACS before ever doing
a security send / receive.
