> On 11 Feb 2017, at 12:43, Wouter Verhelst <w@xxxxxxx> wrote: > >>> Interesting. Some input into the info extension (re blocksizes) would >>> definitely be appreciated. >>> >> >> What do you mean? Right now the client is just calling NBD_SET_BLKSIZE >> with 4k blocksize since all of our devices are 4k drives. Thanks, > > He's talking about > <https://github.com/NetworkBlockDevice/nbd/blob/extension-info/doc/proto.md#block-size-constraints>, > which is a protocol extension that hasn't been implemented yet but would > be relevant to this patch. Indeed. Specifically, review of the patch from a kernel perspective would be useful. -- Alex Bligh