On Wed 01-02-17 01:53:20, Christoph Hellwig wrote: > Looks fine: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > But can you also add another patch to kill off blk_get_backing_dev_info? > The direct dereference is short and cleaner. Additionally the bt_bdi > field in XFS could go away, too. OK, I'll do that. Another cleanup I was considering is to remove all other embedded occurences of backing_dev_info and make the structure only dynamically allocated. It would unify the handling of backing_dev_info and allow us to make bdi_init(), bdi_destroy(), etc. static inside mm/backing_dev.c. What do you think? Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html