>>>>> "Christoph" == Christoph Hellwig <hch@xxxxxx> writes: Christoph> Return an errno value instead of the passed in queue so that Christoph> the callers don't have to keep track of two queues, and move Christoph> the assignment of the request_fn and lock to the caller as Christoph> passing them as argument doesn't simplify anything. While Christoph> we're at it also remove two pointless NULL assignments, given Christoph> that the request structure is zeroed on allocation. Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html