On 01/23/2017 02:20 AM, Johannes Thumshirn wrote: > On Sun, Jan 22, 2017 at 09:33:08AM +0100, SF Markus Elfring wrote: >> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> >> Date: Sat, 21 Jan 2017 22:15:33 +0100 >> >> The script "checkpatch.pl" pointed information out like the following. >> >> ERROR: do not use assignment in if condition >> >> Thus fix the affected source code places. >> >> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> >> --- > > Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx> > if Jens wants doesn't mind. I don't mind these, but I completely agree on the patches for moving the 'error' assignment. What ends up happening for those cases is that someone adds a new section and forgets to set 'error', and then all hell breaks lose. So Markus, don't bother sending those patches again for the block layer or drivers, I'm not going to take them. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
