Re: [patch] nbd: blk_mq_init_queue returns an error code on failure, not NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/09/2017 01:27 PM, Omar Sandoval wrote:
> On Mon, Jan 09, 2017 at 03:20:31PM -0500, Jeff Moyer wrote:
>> Additionally, don't assign directly to disk->queue, otherwise
>> blk_put_queue (called via put_disk) will choke (panic) on the errno
>> stored there.
>>
>> Bug found by code inspection after Omar found a similar issue in
>> virtio_blk.  Compile-tested only.
>>
>> Signed-off-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
> 
> Reviewed-by: Omar Sandoval <osandov@xxxxxx>
> 
> Compile-reviewed only :) Josef can probably test it if he cares enough,
> but it looks right.

Looks good to me, too. Josef, you want me to queue this up directly?

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux