Re: [PATCH 2/7] blk-mq: abstract out blk_mq_dispatch_rq_list() helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/13/2016 10:18 AM, Ritesh Harjani wrote:
On 12/9/2016 1:43 AM, Jens Axboe wrote:
+    if (!list_empty_careful(&hctx->dispatch)) {
+        spin_lock(&hctx->lock);
+        if (!list_empty(&hctx->dispatch))
list_splice_init already checks for list_empty. So this may be
redundant. Please check.

Hello Ritesh,

I think the list_empty() check is on purpose and is intended as a performance optimization.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux