Hello, On Tue, Nov 22, 2016 at 03:18:24PM -0800, Shaohua Li wrote: > Hmm, it's not a real 'time slice'. The name is a bit confusion. Maybe rename it > to 'throtl_interval' or 'throtl_sampling_time'? not sure. bandwidth and iops > are always in terms of a time interval we measure them. We can't say the > iops/bw for a single io. So this is really a tuable knob. Yeah, maybe using a more indicative name is better. However, even if we say that this is the sampling period, it's not clear how adjusting the knob would affect the behavior as that's not something clearly defined in blk-throtl's operation model. For contrast, compare it with the latency target, the implemented behavior might not succeed to follow the intended configuration perfectly but what the intention of the configuration is clear regardless. That said, if this needs to be a tunable knob, it's fine to have it, but let's at least try to document what the effects of changing the variable is. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
