On Tue, Nov 01, 2016 at 10:18:13AM +0200, Sagi Grimberg wrote:
> > - spin_lock_irq(&nvmeq->q_lock);
> > + spin_lock_irqsave(&nvmeq->q_lock, flags);
> > if (unlikely(nvmeq->cq_vector < 0)) {
> > if (ns && !test_bit(NVME_NS_DEAD, &ns->flags))
> > ret = BLK_MQ_RQ_QUEUE_BUSY;
> > else
> > ret = BLK_MQ_RQ_QUEUE_ERROR;
> > - spin_unlock_irq(&nvmeq->q_lock);
> > + spin_unlock_irqrestore(&nvmeq->q_lock, flags);
> > goto out;
> > }
> > __nvme_submit_cmd(nvmeq, &cmnd);
> > nvme_process_cq(nvmeq);
> > - spin_unlock_irq(&nvmeq->q_lock);
> > + spin_unlock_irqrestore(&nvmeq->q_lock, flags);
>
> No documentation why this is needed...
Let's forget documenting why it's needed; this solution should instead
figure out a way to make it so it's not needed.
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
