On Mon, Oct 31, 2016 at 11:11 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Mon, Oct 31, 2016 at 09:59:43AM -0400, Theodore Ts'o wrote: >> What is _rd and _wt supposed to stand for? > > I think it's read and write, but I think the naming is highly > unfortunate. I started dabbling around with the patches a bit, > and to keep my sanity a started reaming it to _pages and _bvec > which is the real semantics - the _rd or _pages gives you a synthetic > bvec for each page, and the other one gives you the full bvec. Looks _pages & _bvec is better and still a little confusing and not reflect its real purpose from user view, since both points to real bvec. Could we just rename _rd as bio_for_each_segment_all_ro() which means the pointed bvec is readonly and not introduce _wt? Thanks, Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
