Re: [PATCH 26/60] btrfs: set NO_MP for request queues behind BTRFS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 31, 2016 at 08:36:44AM -0700, Christoph Hellwig wrote:
On Sat, Oct 29, 2016 at 04:08:25PM +0800, Ming Lei wrote:
There are lots of direct access to .bi_vcnt & .bi_io_vec
of bio, and it isn't ready to support multipage bvecs
for BTRFS, so set NO_MP for these request queues.

For one bio is an I/O submitter, it has absolutely no business changing
queue flags - if we need to stick to this limitation it simply needs
a version of bio_add_page that doesn't create multi-page bvecs.

Second I don't think making it multipage bvec aware is all that hard,
and we should aim for doing the proper thing.

Yeah, I'd rather make us less special. The direct access was a short term fix to adjust to the new bio interfaces, we should clean it up.

-chris

--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux