On Tue, Oct 18, 2016 at 11:58 AM, Jeff Moyer <jmoyer@xxxxxxxxxx> wrote:
> Damien Le Moal <damien.lemoal@xxxxxxx> writes:
>
>> + if (!is_power_of_2(zone_blocks)) {
>> + if (sdkp->first_scan)
>> + sd_printk(KERN_NOTICE, sdkp,
>> + "Devices with non power of 2 zone "
>> + "size are not supported\n");
>> + return -ENODEV;
>> + }
>
> Are power of 2 zone sizes required by the standard? I see why you've
> done this, but I wonder if we're artificially limiting the
> implementation, and whether there will be valid devices on the market
> that simply won't work with Linux because of this.
The standard does not require power of 2 zones.
That said, I am not aware of any current (or planned) devices other
than a power of 2.
Common zone sizes I am aware of: 256MiB, 128MiB and 1GiB.
Also note that we are excluding the runt zone from the power of 2 expectation.
So conforming devices should (excluding a runt zone):
- Have zones of the same size.
- Choose a zone size that is a power of 2.
--Shaun
> -Jeff
> --
> To unsubscribe from this list: send the line "unsubscribe linux-block" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at https://urldefense.proofpoint.com/v2/url?u=http-3A__vger.kernel.org_majordomo-2Dinfo.html&d=DQIBAg&c=IGDlg0lD0b-nebmJJ0Kp8A&r=Wg5NqlNlVTT7Ugl8V50qIHLe856QW0qfG3WVYGOrWzA&m=A15hLQb19nr4vdRr1Bbbn98FLSj_y-C0VI6FtiA9V_I&s=rVkinUiv-ZJHIfhlk2VVJM7S2dJtvxOCmwbKMuiOCPU&e=
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
