On 10/11/2016 02:40 PM, Adam Manzanares wrote:
Patch adds an association between iocontext ioprio and the ioprio of a request. This feature is only enabled if a queue flag is set to indicate that requests should have ioprio associated with them. The queue flag is exposed as the req_prio queue sysfs entry.
Honestly, I don't get this patchset. For the normal file system path, we inherit the iocontext priority into the bio. That in turns gets inherited by the request. Why is this any different? It'd be much cleaner to just have 'rq' inherit the IO priority from the io context when the 'rq' is allocated, and ensuring that we inherit and override this if the bio has one set instead. It should already work like that. And in no way should we add some sysfs file to control this, that is nuts. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
