On Tue, Sep 27, 2016 at 08:26:19AM +0200, Hannes Reinecke wrote:
> On 09/26/2016 08:27 PM, Bart Van Assche wrote:
> > Move the blk_freeze_queue() and blk_unfreeze_queue() implementations
> > from block/blk-mq.c to block/blk-core.c. Drop "_mq" from the name of
> > the functions that have been moved.
> >
> > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> > ---
> > block/blk-core.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
> > block/blk-mq.c | 41 +++--------------------------------------
> > block/blk.h | 3 +++
> > 3 files changed, 51 insertions(+), 38 deletions(-)
> >
> > diff --git a/block/blk-core.c b/block/blk-core.c
> > index b75d688..8cc8006 100644
> > --- a/block/blk-core.c
> > +++ b/block/blk-core.c
> > @@ -682,6 +682,51 @@ static void blk_queue_usage_counter_release(struct percpu_ref *ref)
> > wake_up_all(&q->mq_freeze_wq);
> > }
> >
> > +void blk_freeze_queue_start(struct request_queue *q)
> > +{
> > + int freeze_depth;
> > +
> > + freeze_depth = atomic_inc_return(&q->mq_freeze_depth);
> > + if (freeze_depth == 1) {
> > + percpu_ref_kill(&q->q_usage_counter);
> > + blk_mq_run_hw_queues(q, false);
> > + }
> > +}
> > +
> As you dropped the 'mq_' prefix, maybe you should rename the counter to
> 'freeze_depth', to?
See PATCH 6/9
--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
