Christoph, On 9/27/16 01:37, Christoph Hellwig wrote: >> -/* >> - * Zone type. >> - */ >> -enum blk_zone_type { >> - BLK_ZONE_TYPE_UNKNOWN, >> - BLK_ZONE_TYPE_CONVENTIONAL, >> - BLK_ZONE_TYPE_SEQWRITE_REQ, >> - BLK_ZONE_TYPE_SEQWRITE_PREF, >> -}; > > Please don't move this code around after it was added just two > patches earlier. I'd say just split adding the new blkzoned.h > uapi header into a patch of it's own and add that before the > core block code. Or we could just simply merge patches 5 and 7... Even more simple. Would that be OK ? Shaun, any objection ? Best regards. -- Damien Le Moal, Ph.D. Sr. Manager, System Software Group, HGST Research, HGST, a Western Digital brand Damien.LeMoal@xxxxxxxx (+81) 0466-98-3593 (ext. 513593) 1 kirihara-cho, Fujisawa, Kanagawa, 252-0888 Japan www.hgst.com -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html