Re: [PATCH] sbitmap: don't update the allocation hint on clear after resize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 17, 2016 at 01:39:59PM -0600, Jens Axboe wrote:
> On 09/17/2016 01:20 PM, Omar Sandoval wrote:
> > From: Omar Sandoval <osandov@xxxxxx>
> > 
> > If we have a bunch of high-numbered bits allocated and then we resize
> > the struct sbitmap_queue, when those bits get cleared, we'll update the
> > hint and then have to re-randomize it repeatedly. Avoid that by checking
> > that the cleared bit is still a valid hint. No measurable performance
> > difference in the common case.
> > 
> > Signed-off-by: Omar Sandoval <osandov@xxxxxx>
> > ---
> > Jens,
> > 
> > Small tweak to patch 6 that occurred to me after I sent the series out.
> > Feel free to fold it in to patch 6 or apply it separately as you see
> > fit.
> 
> No worries. I can't fold since the series was already applied, so I just
> added the extra patch.
> 

Okay with me, thanks!

-- 
Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux