On Sun, Aug 21, 2016 at 05:31:33PM +0800, Ming Lei wrote: > This patch is definitely correct, and I don't see dealing with 'no_merge' > should be removed. > > In this case, the bio is still possible to merge with others because > it doesn't violate any limit of the queue because it just can't be held in > 256 bvecs, that means it is correct to clear no_merge for this situation. > > Also I don't think it is complicated or ugly to deal with the flag. It's extra unnecessary code. All other things being equal, less code is always better than more code. It works just fine without it, what's the justification for adding the flag? Don't be so dismissive of other maintainer's concerns, we've got to deal with this code too. Especially when I and Christoph are agreeing on something - how often does that happen? -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
