On 14 August 2016 at 17:00, Tom Yan <tom.ty89@xxxxxxxxx> wrote: > > That won't really work. min_t() would, though the line is gonna be a > bit long; not sure if I can/should simply cast the type (unsigned int) > to BLK_DEF_MAX_SECTORS. And which braces are you referring to? > Oh you mean the else-clause braces. Hmm I thought the coding style was that if you needed braces in one clause, you should use braces for others in the condition even if it consists of only one line of statement. At least that is what I was told when I send patches for libata. So, should I use min_t() or just do a type casting in front to BLK_DEF_MAX_SECTORS? Also do I need to break the line at a certain point when it exceeds certain length? -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
