On Fri, Aug 05, 2016 at 12:18:55PM +1000, Dave Chinner wrote: > Give this is being spread all over the kernel way outside the block > layer and IO path, shouldn't this have some kind of namespace > component to the name? i.e "req_op_is_write()"? The READ/WRITE #defines alias to the request ops, so this helper is rather global as well. Not that I like it, but it will take a while to clean that up, including making various things __bitwise annotated enums to get proper sparse type checking. -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html