On Wed, Jun 22, 2016 at 09:53:04AM -0400, Martin K. Petersen wrote: > >>>>> "Christoph" == Christoph Hellwig <hch@xxxxxx> writes: > > Christoph, > > Christoph> Unlike discard outside the zeroout path, write same is a data > Christoph> integrity operation. Just like in the zero out case turning > Christoph> an EOPNOTSUPP into 0 will get you data corruption, as the > Christoph> caller will see a successful return for an operation that did > Christoph> not actually write data to disk. > > Exactly. So why add the dreaded -EOPNOTSUPP special casing to > blkdev_issue_write_same()? This is a leftover from bio_batch_end_io and not new behavior. But I agree that we should kill it. -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html