Christoph Hellwig <hch@xxxxxx> writes: >> > if (flags & BLKDEV_DISCARD_SECURE) { >> > + if (flags & BLKDEV_DISCARD_ZERO) >> > + return -EOPNOTSUPP; >> >> Should this be -EINVAL? > > BLKDEV_DISCARD_SECURE | BLKDEV_DISCARD_ZERO seems like a theoretically > possible case, but I don't really care.. I agree, that is a possible combination. EOPNOTSUPP is fine. -Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html