On Mon, Jun 13, 2016 at 08:17:38PM -0600, Jens Axboe wrote: > It may be awkward, but we have those to avoid doing things like this: > > + rq->__data_len = 0; > + rq->__sector = (sector_t) -1; > + rq->bio = rq->biotail = NULL; > + memset(rq->__cmd, 0, sizeof(rq->__cmd)); > > for every request we allocate, when we don't use ->cmd at all. Honest, I'd > rather have > > struct request *blk_get_pc_request(); > > and similar helpers around this, so we don't have to do extra > initialization when we don't need it. I'm working on resurrecting my patch to remove rq->cmd and friends from the common request structure, but the full patch is something I'd rather do after the initial NVMe over Fabrics merge. If you're fine with the rest of the series I'll respin it to keep blk_set_block_pc for now which will only do the zeroing and setting cmd_type. -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
