>>>>> "Mike" == Mike Snitzer <snitzer@xxxxxxxxxx> writes: Mike> But hch was originally in favor of _always_ dropping EOPNOTSUPP on Mike> the floor (that is what his commit 38f25255330 did). Then he said Mike> he disagrees with these interfaces playing games with masking Mike> EOPNOTSUPP -- to which you seemingly really don't agree. Unless Mike> I'm completely misreading you. Userland apps rely on EOPNOTSUPP, we can't break that. What I don't like this is "soft" error special casing of EOPNOTSUPP in the actual implementation of discard, write same, etc. These functions should return either success or failure. And the ioctl wrapper should then decide whether to return EOPNOTSUPP, EIO or EPONIES. I.e. separate the policy from the implementation. This would also solve some of the grievances for the target folks. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
