Re: [PATCH 1/1] block: Use per-cpu partition in_flight counters.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/10/2016 04:09 PM, Michael Callahan wrote:
Move the partition in_flight counters from hd_struct to disk_stats so
that they become tracked on a per-cpu basis.

Sign-off-by: Michael Callahan <michaelcallahan@xxxxxx>

^^ Signed-off-by

---

This patch is incomplete as it just comments out use of in_flight in dm.c as
that code tracks io statistics in it's own special way.  Any thoughts on
how to fix dm.c are welcome.

This has been done and rejected before. The problem is that you are now having to do a full per cpu loop in part_in_flight(), which is a non-starter. Unless you can make that part more clever, than it's not going to be a great idea.

Generally, doing patches like this, you should include test results showing why this is a good idea. A good commit message is a "why" for the patch.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux