On Fri, May 06, 2016 at 06:44:35PM +0200, Christoph Hellwig wrote: > On Fri, May 06, 2016 at 05:36:58PM +0100, Joe Thornber wrote: > > But the plugging and error handling are called from two places. > > process_prepared_discard_passdown() and > > passdown_double_checking_shared_status(). > > passdown_double_checking_shared_status is only called from > process_prepared_discard_passdown. So the blk_start_plug from > begin_discard and the work in end_discard could be moved into > it trivially. Good point, will do. Thx. -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html