So I dropped a handful of spaces in genhd.c:diskstats_show while I was making it prettier. Smashing them back in fixes iostat without the -p option. Sorry about that. Any other similar programs to worry about? On Thu, May 5, 2016 at 11:48 AM, Michael Callahan <coder.callahan@xxxxxxxxx> wrote: > On Thu, May 5, 2016 at 11:29 AM, Jeff Moyer <jmoyer@xxxxxxxxxx> wrote: >> Michael Callahan <coder.callahan@xxxxxxxxx> writes: >> >>> Tested iostat more and it appears to work fine with this patch. >> >> What exactly did you test? I've got sysstat 10.1.5 here, and with your >> patch, I get no statistics output from iostat -x: >> >> # iostat -x >> Linux 4.6.0-rc5+ (slayer.lab.bos.redhat.com) 05/05/16 _x86_64_ (4 CPU) >> >> avg-cpu: %user %nice %system %iowait %steal %idle >> 0.31 0.00 0.17 0.52 0.00 99.00 >> >> Device: rrqm/s wrqm/s r/s w/s rkB/s wkB/s avgrq-sz avgqu-sz await r_await w_await svctm %util >> >> # >> >> I just grabbed 11.3.4, and it also shows the same behavior. >> >> Cheers, >> Jeff > > I tried 'iostat -p ALL' with and without the x. I suppose the code > that automatically determines which devices to display could be > broken. > > Michael -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
